Open
Conversation
IhateTrains
temporarily deployed
to
Build Environment
GitHub Actions
Inactive
IhateTrains
temporarily deployed
to
Build Environment
GitHub Actions
Inactive
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
IhateTrains
temporarily deployed
to
Build Environment
GitHub Actions
Inactive
IhateTrains
temporarily deployed
to
Build Environment
GitHub Actions
Inactive
IhateTrains
temporarily deployed
to
Build Environment
GitHub Actions
Inactive
IhateTrains
temporarily deployed
to
Build Environment
GitHub Actions
Inactive
IhateTrains
temporarily deployed
to
Build Environment
GitHub Actions
Inactive
|
Coverage is 57.278% — wtwsms-compatch into master. No base build found for |
IhateTrains
temporarily deployed
to
Build Environment
GitHub Actions
Inactive
| link = { imp = 2030 ck3 = 1517 } # Sinomagus -> DUNMOW | ||
| link = { imp = 2034 ck3 = 1534 ck3 = 1533 } # Duroliponte -> CAMBRIDGE, HERTFORD | ||
| link = { imp = 2052 ck3 = 1541 ck3 = 1543 ck3 = 1536 } # Durovigutum -> HURSTINGSTONE, LEIGHTONSTONE, PAPWORTH | ||
| link = |
There was a problem hiding this comment.
[misspell] reported by reviewdog 🐶
"TYRE" is a misspelling of "TIRE"
| link = { imp = 2030 ck3 = 1517 } # Sinomagus -> DUNMOW | ||
| link = { imp = 2034 ck3 = 1534 ck3 = 1533 } # Duroliponte -> CAMBRIDGE, HERTFORD | ||
| link = { imp = 2052 ck3 = 1541 ck3 = 1543 ck3 = 1536 } # Durovigutum -> HURSTINGSTONE, LEIGHTONSTONE, PAPWORTH | ||
| link = |
There was a problem hiding this comment.
[misspell] reported by reviewdog 🐶
"Stange" is a misspelling of "Strange"
Dominant heritage was Chinese, which has no empire mapped as intended.
IhateTrains
force-pushed
the
wtwsms-compatch
branch
from
ea3b1b9 to
c6365e5
Compare
IhateTrains
temporarily deployed
to
Build Environment
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
k_xianot having any de jure empire. Previously the converter tried to assign an empire based on the dominant heritage in the kingdom (Chinese), but because the Chinese heritage has intentionally no heritage->empire mapping, the kingdom was skipped. Now the converter iterates over all heritages in the kingdom (from dominant to least present) until a usable heritage is found.closes #3056